diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a9cad9ac56..6ff563e7229 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## main / unreleased +* [ENHANCEMENT] Remove hardcoded delay in distributor shutdown [#3687](https://github.com/grafana/tempo/pull/3687) (@chodges15) * [ENHANCEMENT] Update OTLP and add attributes to instrumentation scope in vParquet4 [#3649](https://github.com/grafana/tempo/pull/3649) (@stoewer) **Breaking Change** The update to OTLP 1.3.0 removes the deprecated `InstrumentationLibrary` and `InstrumentationLibrarySpan` from the OTLP receivers diff --git a/modules/distributor/receiver/shim.go b/modules/distributor/receiver/shim.go index f043e548ba1..fe3c3ae02b0 100644 --- a/modules/distributor/receiver/shim.go +++ b/modules/distributor/receiver/shim.go @@ -305,12 +305,6 @@ func (r *receiversShim) starting(ctx context.Context) error { // Called after distributor is asked to stop via StopAsync. func (r *receiversShim) stopping(_ error) error { - // when shutdown is called on the receiver it immediately shuts down its connection - // which drops requests on the floor. at this point in the shutdown process - // the readiness handler is already down so we are not receiving any more requests. - // sleep for 30 seconds to here to all pending requests to finish. - time.Sleep(30 * time.Second) - ctx, cancelFn := context.WithTimeout(context.Background(), 30*time.Second) defer cancelFn()