Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo Metrics Generation uses different metrics labels to Grafana Agent #1444

Closed
hedss opened this issue May 24, 2022 · 2 comments · Fixed by #1478
Closed

Tempo Metrics Generation uses different metrics labels to Grafana Agent #1444

hedss opened this issue May 24, 2022 · 2 comments · Fixed by #1478
Labels
component/metrics-generator type/docs Improvements or additions to documentation

Comments

@hedss
Copy link
Contributor

hedss commented May 24, 2022

Is your feature request related to a problem? Please describe.
In Grafana Agent, the generated metrics labels are:

traces_spanmetrics_latency_sum
traces_spanmetrics_latency_count
traces_spanmetrics_latency_bucket
traces_spanmetrics_call_counts

In Tempo metrics server side we generate metrics called:

traces_spanmetrics_duration_seconds_sum
traces_spanmetrics_duration_seconds_count
traces_spanmetrics_duration_seconds_bucket
traces_spanmetrics_call_counts

Obviously, the first three differ between the Agent and Tempo.

There is also a difference on the label for the status code, in Grafana Agent it's:

status_code

and in Tempo metrics generation it's:

span_status

Describe the solution you'd like
We should either consider altering these to the OTel standard, or at least documenting these differences so that should users change from Grafana Agent metrics generation to Tempo, they understand the changes they will need to make.

Describe alternatives you've considered
N/A

Additional context
N/A

@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label May 24, 2022
@knylander-grafana
Copy link
Contributor

@hedss On the documentation side, is this something that might be handled by a UI error message warning the user?

@hedss
Copy link
Contributor Author

hedss commented May 24, 2022

@knylander-grafana That's an interesting question, but Grafana would probably need to understand that trace span metrics are being received and the user's not requesting the right ones, so it'd need to look at panels using those names (or the Explorer). Not sure how viable this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics-generator type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants