Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue searching backend even if a trace is found in the ingesters #344

Closed
joe-elliott opened this issue Nov 16, 2020 · 2 comments
Closed

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
As part of our plans to support "exhaustive search" for traces let's search the backend even if the ingesters return a result. This is related to #161.

Describe the solution you'd like
Continue searching the backend even if the ingesters succeed and combine the results.

Additional context
@annanay25 we need to consider this as we move forward with the query frontend. I'm thinking we will add a number of parameters to the GET /api/traces/xxxxxx endpoint that the query frontend can use for sharding like:

GET /api/traces/xxx?startblock=xxx&endblock=xxx&ingesters=false

By default the /api/traces/xxx endpoint should just search everything.

@annanay25
Copy link
Contributor

I'm thinking we will add a number of parameters to the GET /api/traces/xxxxxx endpoint that the query frontend can use for sharding

Precisely what I was thinking as well. I'll have something more concrete to share soon.

@joe-elliott
Copy link
Member Author

Fixed in #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants