You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the formatters introduced in e.g. in #56 and #59, there are a number of calls to cue.Value.Eval(). IIRC, i used these originally as a quick hack to eliminate printed references to the lineage's joinSchema.
I knew it was suboptimal at the time and left in a bunch of TODOs to remove, but the immediate impacts of doing it did not occur to me. Now that i've tried it against Grafana's dashboard lineage, though, i realized that the eval call definitely eliminates field/list comprehensions. That changes the semantics of the dashboard, which needs those for its (current approach to) composition.
While that hacky composition approach is almost certain to change with #8 - like, that comprehension should probably not be in the body of the schema - it just emphasized to me just how important it is to preserve the original, textual input from the user for these cases.
The text was updated successfully, but these errors were encountered:
In the formatters introduced in e.g. in #56 and #59, there are a number of calls to
cue.Value.Eval()
. IIRC, i used these originally as a quick hack to eliminate printed references to the lineage'sjoinSchema
.I knew it was suboptimal at the time and left in a bunch of TODOs to remove, but the immediate impacts of doing it did not occur to me. Now that i've tried it against Grafana's dashboard lineage, though, i realized that the eval call definitely eliminates field/list comprehensions. That changes the semantics of the dashboard, which needs those for its (current approach to) composition.
While that hacky composition approach is almost certain to change with #8 - like, that comprehension should probably not be in the body of the schema - it just emphasized to me just how important it is to preserve the original, textual input from the user for these cases.
The text was updated successfully, but these errors were encountered: