Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate WebCryptoAPI/import_export/importKey_failures.js test #4261

Open
olegbespalov opened this issue Oct 26, 2024 · 0 comments
Open

Activate WebCryptoAPI/import_export/importKey_failures.js test #4261

olegbespalov opened this issue Oct 26, 2024 · 0 comments

Comments

@olegbespalov
Copy link
Contributor

olegbespalov commented Oct 26, 2024

What?

While we implemented support for elliptic curve algorithms (#67 and grafana/xk6-webcrypto#69), we missed the Web Platform Test WebCryptoAPI/import_export/importKey_failures.js, which tests some negatives for the import keys.

It is worth activating it (please see https://github.com/grafana/xk6-webcrypto/tree/main/webcrypto/tests), which probably could also cause some adjustments in implementation.

At the moment of writing issue, we do support two algorithms from there (ECDH and ECDSA), but depending on the state of the extension, it could be more.

Why?

Testing against the Web Platform Test suite is essential since it gives some confidence about the implementation.

@olegbespalov olegbespalov transferred this issue from grafana/xk6-webcrypto Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant