Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle XSS in search results #28

Open
code-inflation opened this issue Nov 27, 2018 · 0 comments
Open

Properly handle XSS in search results #28

code-inflation opened this issue Nov 27, 2018 · 0 comments
Labels
backlog bug Something isn't working

Comments

@code-inflation
Copy link
Contributor

Describe the bug
The highlighting of the search results is currently done using dangerouslySetInnerHTML. This may be a XSS vulnerability and has to be fixed.

Fix
The highlighting of the search results has to be handled differently. Maybe with the same markdown render that we could use for the article content.
@code-inflation code-inflation added bug Something isn't working backlog labels Nov 27, 2018
@issue-sh issue-sh bot added this to the Sprint 4 milestone Nov 30, 2018
@disperate disperate removed this from the Sprint 4 milestone Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code-inflation @disperate