-
Notifications
You must be signed in to change notification settings - Fork 576
Conversation
Probably should think about other types of caches as well: cookies, local-storage, indexDB and more. |
@joelgriffith good point, but ApplicationCache & CacheStorage are now Talking about IndexedDB & Serviceworker, those features do not call their data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to keep this open for so long, but I think we're wanting to name things with verb
first, so in this case clearCache
. Could you make this change? Otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joeyvandijk!
👍 Same applies for PR 123 btw 😉 or do you want the name change also there? |
@joeyvandijk Yes please! We're settling on a |
@joelgriffith can you review again? ;) |
@joeyvandijk Sorry, another thing:
As part of this PR, could you add a note about that in the API documentation? Just to set peoples expectations about which cache gets cleared (and which things don't get cleared.) |
@joelgriffith @adieuadieu have updated, but am not 100% sure if I am right, while the documentation is quite limited in its explanations. But thats why PRs exists 😉 to update it with the correct information if I am wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joeyvandijk! This looks good.
You're welcome 👍 😄 |
To prevent data is cached from a previous browser session provide the functionality to clear the cache whenever needed.