Skip to content
This repository was archived by the owner on Nov 24, 2018. It is now read-only.

provide .clearCache() functionality #122

Merged
merged 8 commits into from
Aug 4, 2017

Conversation

joeyvandijk
Copy link
Contributor

To prevent data is cached from a previous browser session provide the functionality to clear the cache whenever needed.

@joeyvandijk joeyvandijk changed the title provide browser cacheClear functionality provide .cacheClear functionality Aug 1, 2017
@joeyvandijk joeyvandijk changed the title provide .cacheClear functionality provide .cacheClear() functionality Aug 1, 2017
@joelgriffith
Copy link
Contributor

Probably should think about other types of caches as well: cookies, local-storage, indexDB and more.

@joeyvandijk
Copy link
Contributor Author

@joelgriffith good point, but ApplicationCache & CacheStorage are now experimental and I can't find if they are a more specific way of managing cache or only meant for local-storage, etc?

Talking about IndexedDB & Serviceworker, those features do not call their data cache in any way and therefore I think we should name them as they are mentioned in the Devtools protocol documentation.
Perhaps we should make this clear in the documentation around cacheClear what it does(n't) do! But this is what I know, can find, so perhaps people can later on (here or with other PRs) add this information?

Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep this open for so long, but I think we're wanting to name things with verb first, so in this case clearCache. Could you make this change? Otherwise looks great!

Copy link
Collaborator

@adieuadieu adieuadieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joeyvandijk!

@adieuadieu adieuadieu added this to the v1.2 milestone Aug 3, 2017
@joeyvandijk
Copy link
Contributor Author

👍 Same applies for PR 123 btw 😉 or do you want the name change also there?

@adieuadieu
Copy link
Collaborator

@joeyvandijk Yes please! We're settling on a verbNoun() API method naming convention.

@adieuadieu adieuadieu changed the title provide .cacheClear() functionality provide .clearCache() functionality Aug 3, 2017
@joeyvandijk
Copy link
Contributor Author

@joelgriffith can you review again? ;)

@adieuadieu
Copy link
Collaborator

@joeyvandijk Sorry, another thing:

Talking about IndexedDB & Serviceworker, those features do not call their data cache in any way and therefore I think we should name them as they are mentioned in the Devtools protocol documentation.
Perhaps we should make this clear in the documentation around cacheClear what it does(n't) do! But this is what I know, can find, so perhaps people can later on (here or with other PRs) add this information?

As part of this PR, could you add a note about that in the API documentation? Just to set peoples expectations about which cache gets cleared (and which things don't get cleared.)

@joeyvandijk
Copy link
Contributor Author

joeyvandijk commented Aug 3, 2017

@joelgriffith @adieuadieu have updated, but am not 100% sure if I am right, while the documentation is quite limited in its explanations. But thats why PRs exists 😉 to update it with the correct information if I am wrong.

Copy link
Collaborator

@adieuadieu adieuadieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joeyvandijk! This looks good.

@adieuadieu adieuadieu merged commit 718233c into schickling:master Aug 4, 2017
@joeyvandijk
Copy link
Contributor Author

You're welcome 👍 😄

@joeyvandijk joeyvandijk deleted the feature/cacheClear branch August 6, 2017 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants