Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AMQP by Default #219

Closed
EstebanBorai opened this issue Jul 5, 2023 · 4 comments
Closed

Enable AMQP by Default #219

EstebanBorai opened this issue Jul 5, 2023 · 4 comments
Labels

Comments

@EstebanBorai
Copy link

Hi! Im using this image to work with Graphite my goal is to feed the database
using AMQP, I noticed that by default AMQP is not enabled, it is possible to enable
AMQP by default using this image?

Looking through settings on: https://github.com/graphite-project/docker-graphite-statsd#tunables
I didn't found any environment variables related to AMQP.

Thanks in advance!

@deniszh
Copy link
Member

deniszh commented Jul 6, 2023

Hi @EstebanBorai ,

Not sure if enabling AMQP by default is a good idea, but we can make it configurable, indeed.

@EstebanBorai
Copy link
Author

Thanks for the quick response @deniszh!

Making it configurable would be great! What Im doing today is manually edit the carbon.conf file using the Docker volume after the first run, and then I restart the container.

So having an environment variable like AMQP_ENABLED would be awesome. Other AMQP params such as host, port, user, password as environment variables would also come handy, this way we can spin up the container with the configuration on the first run!

@deniszh
Copy link
Member

deniszh commented Jul 9, 2023

Fixed in #220
New release baked in #221, should be available soon.

@deniszh deniszh closed this as completed Jul 9, 2023
@EstebanBorai
Copy link
Author

Thanks a lot @deniszh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants