Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter encoding not working as expected. #103

Open
phyllipy opened this issue Oct 20, 2021 · 1 comment
Open

Parameter encoding not working as expected. #103

phyllipy opened this issue Oct 20, 2021 · 1 comment

Comments

@phyllipy
Copy link

When sending filtering data through a where clause, the parameters are not being properly encoded:

value: this&that

Browser: Firefox 93.0 (64-bit) Mac OS Big Sur

Screen Shot 2021-10-21 at 11 35 40
Screen Shot 2021-10-21 at 11 35 55

Google Chrome 94.0.4606.81 (Official Build) (x86_64) (Big Sur)

Screen Shot 2021-10-21 at 11 37 44

Screen Shot 2021-10-21 at 11 38 02

@garethsparks
Copy link

garethsparks commented Nov 17, 2021

Same issue in chrome: browser encodes it automatically except for ampersands, which break the query. Easily fixed in front end by pre-encoding the string, but makes for surprise edge cases with values that contain ampersands. I couldn't figure out any reason for spraypaint not to pre-encode the value regardless of browser, but maybe I'm missing something.

But I also think we should improve the check to minimize edge cases with a "%" that could also be problematic (see phyllipy#1 -- this tests for absence of encoded values (%[0-9a-z]{2}) and also confirms no un-encoded (but encodable) chars are in the text other than %.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants