Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspection queries stop working after a subgraph has encountered an indexing error #2443

Closed
fubhy opened this issue May 7, 2021 · 1 comment · Fixed by #4968
Closed
Assignees
Labels
area/graphql bug Something isn't working

Comments

@fubhy
Copy link
Member

fubhy commented May 7, 2021

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Introspection queries fail after a subgraph has encountered an indexing error.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
This potentially also happens if the subgraph flat fails (not sure) but we encountered it whilst using the nonFatalErrors feature. Hence:

  1. Deploy a failing subgraph using the nonFatalErrors feature
  2. Wait for it to fail and then try to run a schema introspection or type query
  3. The query returns message: indexing_error

What is the expected behavior?
Even if a subgraph has failed, introspection queries should always work (both when using the nonFatalErrors feature or not). The schema is immutable and not affected by any indexing errors.

The __schema and __type fields are part of the spec and used by various tooling. Hence, adding a subgraphErrors: allow input field to those fields wouldn't work well. Instead, both __type and __schema should simply always work.

@leoyvens leoyvens added the bug Something isn't working label May 7, 2021
@Jannis Jannis moved this to Todo in GraphQL API Dec 6, 2021
@mshakeg
Copy link

mshakeg commented Feb 1, 2023

Hi @leoyvens , would it be possible to get this addressed? This issue has been open for quite a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants