Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subgraph runner #5499

Open
mangas opened this issue Jun 18, 2024 · 1 comment
Open

Refactor subgraph runner #5499

mangas opened this issue Jun 18, 2024 · 1 comment
Labels

Comments

@mangas
Copy link
Contributor

mangas commented Jun 18, 2024

Subgraph runner has some code duplication and a lot of if-else-ish code. We should try to improve it by making some concerns more isolated and the error more testable.

This is probably going to require several iterations on different parts but the sooner we start the sooner we finish.

As @lutter pointed out, this last PR added some more code duplication which doesn't help #4916 (comment)

Copy link

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.

@github-actions github-actions bot added the Stale label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant