Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: regeneratorRuntime is not defined #2

Closed
czystyl opened this issue Oct 3, 2018 · 5 comments
Closed

ReferenceError: regeneratorRuntime is not defined #2

czystyl opened this issue Oct 3, 2018 · 5 comments

Comments

@czystyl
Copy link
Member

czystyl commented Oct 3, 2018

No description provided.

@sibelius
Copy link

sibelius commented Oct 3, 2018

you should polyfill babel-polyfill to make this work

@czystyl
Copy link
Member Author

czystyl commented Nov 5, 2018

Yes, but I'd like to add this to the library and not force the user to install it. What do you think about it?

@sibelius
Copy link

sibelius commented Nov 5, 2018

bad idea, let user polyfill

in some environment polyfill is not needed, so it should not be included

@czystyl
Copy link
Member Author

czystyl commented Nov 5, 2018

Good point, and good idea so we can close it :)

Thanks for your input 👍

@czystyl czystyl closed this as completed Nov 5, 2018
@taylorgoolsby
Copy link
Contributor

Shouldn't transform-runtime be used instead?

regenerator-runtime is no longer a viable option since it does not create a global variable anymore. The suggested method seems to be for third party packages to use transform-runtime. Citation: facebook/regenerator#363 (comment)

babel-polyfill does work, but now that regenerator-runtime is no longer an option, the only option for people who do not want to use babel-polyfill is to use transform-runtime, but transform-runtime must be included in the third party package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants