Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in support for APQ (Persisted Queries) #548

Closed
mikocot opened this issue Apr 21, 2023 · 4 comments · Fixed by #555
Closed

Built-in support for APQ (Persisted Queries) #548

mikocot opened this issue Apr 21, 2023 · 4 comments · Fixed by #555
Labels
enhancement New feature or request

Comments

@mikocot
Copy link
Contributor

mikocot commented Apr 21, 2023 •
edited
Loading

APQ (Automatic Persisted Queries) are strandard and also a requirement for some GraphQL servers and they are also implemented in the graphql-server since 5.3

graphql-dotnet/graphql-dotnet#3134

It would be cool to be able to use this feature out of box with the .net client
Either building the query with some helper methods first, or with opt-in automatic conversion

https://www.apollographql.com/docs/apollo-server/performance/apq/
@sungam3r
Copy link
Member

I have implemented this in other in-house GraphQL client but I think it can be easily ported here.

@rose-a rose-a added the enhancement New feature or request label Apr 24, 2023
@mikocot
Copy link
Contributor Author

mikocot commented Apr 24, 2023 •
edited
Loading

I have implemented this in other in-house GraphQL client but I think it can be easily ported here.

cool, if you dont have time for a full PR maybe you could at least drop some example code here so we can discuss the best approach to start?

@sungam3r sungam3r mentioned this issue Apr 24, 2023
Merged
@mikocot
Copy link
Contributor Author

mikocot commented Apr 25, 2023

thanks @sungam3r, looks like things are moving fast now!

@sungam3r
Copy link
Member

In fact, I am now working in a hurry on a few tasks and cannot fully concentrate on one thing. APQ PR is more like a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add APQ support graphql-dotnet/graphql-client
3 participants
@mikocot @rose-a @sungam3r