Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting execution timeout with gql-cli #347

Closed
gonzalezzfelipe opened this issue Jul 28, 2022 · 1 comment
Closed

Setting execution timeout with gql-cli #347

gonzalezzfelipe opened this issue Jul 28, 2022 · 1 comment
Labels
type: feature A new feature

Comments

@gonzalezzfelipe
Copy link

Describe the bug

There is a default execution_timeout on the client, which can't be modified on the CLI. This means that any request that lasts more than 10 seconds that is done using the gql-cli will fail, and there's nothing the user can do about it. It is possible to add the possiblity to modify this timeout using the CLI arguments, but why have the default timeout at all? I don't see any gain imposing a timeout on the users.

Refferences in the code:

System info (please complete the following information):

  • OS: MacOs
  • Python version: 3.10.4
  • gql version: 3.4.0
  • graphql-core version: 3.2.1
@leszekhanusz
Copy link
Collaborator

Hmm it seems we did the same PR at the same time...

Adding arguments to gql-cli can be done.

Removing the timeout is not an option and increasing the default would be a breaking change and I don't see the point if it is configurable.

@leszekhanusz leszekhanusz added the type: feature A new feature label Jul 28, 2022
@leszekhanusz leszekhanusz changed the title Remove default execution timeout on client Setting execution timeout with gql-cli Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants