fix: headers tab - highlighting and schema fetch #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headers tab does not re-fetch schema with same headers when fetcher prop changes - codemirror mode for json, `graphql-headers` is a non-existant mode
connorshea
reviewed
Jun 23, 2020
| require('codemirror/keymap/sublime'); | ||
|
|
||
| const editor = (this.editor = this.CodeMirror(this._node, { | ||
| value: this.props.value || '', | ||
| lineNumbers: true, | ||
| tabSize: 2, | ||
| mode: 'graphql-headers', | ||
| mode: { name: 'javascript', json: true }, |
There was a problem hiding this comment.
@acao This was done because the variable editor was set to graphql-variables, is that an actual mode or should we change that as well?
There was a problem hiding this comment.
graphql-variables is an actual mode in the codemirror-graphql package in this repo, as you can see in the require() statements
There was a problem hiding this comment.
codemirror is not the simplest to wrap your head around, so I can totally relate with this choice! haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-headersis a non-existant mode