feat: provide validation rules via props

[n1ru4l]

No description provided.

[acao]

awesome start! now you’ll need to make sure that option is used here:

graphiql/packages/codemirror-graphql/src/lint.js

Line 36 in b39c189

const rawResults = getDiagnostics(text, schema);

otherwise, i dont see where codemirror uses options.customValidationRules

[acao]

you can also add this option to monaco graphql in this PR if you want, to be exhaustive.

i was going to add a similar feature to graphiql, codemirror-graphql and monaco now that autocomplete supports external fragment definitions

[acao]

this is a very easy to add and powerful feature for [email protected], i really appreciate your help @n1ru4l !

[acao]

last thing, just needs some basic tests, ideally for graphql-language-service-interface, codemirror-graphql and/or graphiql. i think the first two would be easiest. just pass a simple custom rule and confirm it is used, as an integration test

[acao]

@n1ru4l do you want to update this PR to use the new table format for props?

[n1ru4l]

@acao Sorry for not responding, I will give this a try this evening :)

[codecov]

Codecov Report

Merging #1716 (4b65601) into main (3cecc3d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
+ Coverage   67.06%   67.07%   +0.01%     
==========================================
  Files          87       87              
  Lines        4837     4839       +2     
  Branches     1329     1330       +1     
==========================================
+ Hits         3244     3246       +2     
  Misses       1359     1359              
  Partials      234      234              

Impacted Files	Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx	59.86% <ø> (ø)
packages/codemirror-graphql/src/lint.js	100.00% <100.00%> (ø)
packages/graphiql/src/components/QueryEditor.tsx	63.96% <100.00%> (+0.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cecc3d...4b65601. Read the comment docs.

[n1ru4l]

@acao I added a test for codemirror-graphql and graphql-language-service-interface!

[acao]

fantastic, thank you! all is looking great for this iteration. merging this and I’ll cut a release by the weekend, if not sooner

[acao]

now available in [email protected]!