Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Tab duplicating when using only shouldPersistHeaders. #3107

Closed
1 of 4 tasks
tcK1 opened this issue Mar 20, 2023 · 1 comment
Closed
1 of 4 tasks

[graphiql] Tab duplicating when using only shouldPersistHeaders. #3107

tcK1 opened this issue Mar 20, 2023 · 1 comment

Comments

@tcK1
Copy link

tcK1 commented Mar 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When refreshing (F5 or cmd/ctrl+r) the page, sometimes the current tab is duplicated without the persisted headers.

Expected Behavior

It should not duplicate the tab.

Steps To Reproduce

Comment all these props besides `shouldPersistHeaders: true,`.

https://github.com/graphql/graphiql/blob/9d9478aea7536d2957e4371cef4f30577db2113d/packages/graphiql/resources/renderExample.js#L99-L110

This is also easily reproduced in the wild using the CDN example and setting the `shouldPersistHeaders: true` prop.

Module pattern

  • graphiql-umd
  • graphiql-esm
  • graphiql-commonjs

Environment

- GraphiQL Version: master
- OS: MacOS
- Browser: chrome

Anything else?

No response

@acao
Copy link
Member

acao commented Jul 16, 2023

closing as duplicate of #2825

@acao acao closed this as completed Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants