Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option to show observable results in a log #436

Open
stubailo opened this issue Apr 16, 2017 · 4 comments
Open

Feature: Option to show observable results in a log #436

stubailo opened this issue Apr 16, 2017 · 4 comments

Comments

@stubailo
Copy link

GraphiQL supports both promise and observable fetchers, which let us really easily add support for GraphQL subscriptions. However, this approach just shows the most recent subscription result.

If there was an option somewhere to show a log of all observable results instead of just the most recent one, that would be super useful! I'm not sure if it should be:

  1. The default (given subscriptions might be more common than live queries)
  2. A UI option that appears if your fetcher returns an observable
  3. A prop passed to the component

Or something else.

@stubailo stubailo changed the title Have option to show observable results in a log Feature: Option to show observable results in a log Apr 16, 2017
@wincent
Copy link
Contributor

wincent commented May 6, 2017

Sounds useful.

Exposing this in the UI is hard because it relies on making, gulp, design decisions. I do have some notions for what this could look like, but I am not a designer.

@asiandrummer
Copy link
Contributor

@AGS- worked on getting the history pane, but it doesn't save the results yet. Maybe we should?

@stubailo
Copy link
Author

stubailo commented May 9, 2017

I think to start with, adding a prop to configure this would be sufficient.

@acao
Copy link
Member

acao commented Nov 26, 2021

I don't think graphiql is useful for subscriptions without this feature even - for example, this bug:
#652

this remains an often requested feature now that we have documented support for observables and (async iterables as well - multipart IncrementalDelivery, etc). The IncrementalDelivery appends/sets results for @stream or @defer like it's supposed to, and subscriptions should do something like this ticket describes, and be able to be executed alongside a mutation if possible (this is a common workflow when testing graphql subscriptions!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants