fix: check this.editor exist before this.editor.off in QueryEditor
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes PLSS |
kevinsimper
approved these changes
Apr 11, 2018
|
@whtsky - sorry for not looking at this earlier. If this is still relevant, would you mind rebasing? |
`this.editor` might be undefined if error occured during `componentDidMount`, like graphql#665
whtsky
force-pushed
the
fix/editor_undefined
branch
from
82d61fb to
1395cee
Compare
|
@Neitsch rebased. |
Neitsch
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.editormight be undefined if error occured duringcomponentDidMount, like #665