Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#949 Beautify code tag in doc explorer #959

Merged
merged 1 commit into from
Oct 5, 2019
Merged

#949 Beautify code tag in doc explorer #959

merged 1 commit into from
Oct 5, 2019

Conversation

yroseau
Copy link
Contributor

@yroseau yroseau commented Sep 20, 2019

Sorry for the delay :)

See #949

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #959 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   33.78%   33.78%           
=======================================
  Files          79       79           
  Lines        3481     3481           
  Branches      753      753           
=======================================
  Hits         1176     1176           
  Misses       1814     1814           
  Partials      491      491

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762c3d...0d83c97. Read the comment docs.

@Neitsch
Copy link
Contributor

Neitsch commented Sep 20, 2019

LGTM. @acao - CSS is not my strength. Any concerns here?

@acao
Copy link
Member

acao commented Sep 20, 2019

i was looking through the netlify example but i dont know if we have any concrete examples for this in our test schema. so ill give this a try tonight and see if i can break it, but overall it looks good!

@acao acao merged commit 30810a2 into graphql:master Oct 5, 2019
@acao
Copy link
Member

acao commented Oct 5, 2019

@yroseau merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants