Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: card one of view layout #273

Merged
merged 5 commits into from
Feb 7, 2025
Merged

fix: card one of view layout #273

merged 5 commits into from
Feb 7, 2025

Conversation

itwillwork
Copy link
Contributor

@itwillwork itwillwork commented Feb 7, 2025 •
edited
Loading

Fix bug:

image

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

itwillwork
itwillwork commented Feb 7, 2025
View reviewed changes
src/lib/kit/components/Views/CardOneOfView.tsx
const title = React.useMemo(() => {
const titleProps = {
spec: spec,
value: valueName as any,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like

dynamic-forms/src/lib/kit/components/Views/OneOfView/OneOfView.tsx

Line 53 in aa2963c

<Layout {...props} value={valueName as any}>

@itwillwork itwillwork merged commit dcac2b1 into main Feb 7, 2025
3 of 4 checks passed
@itwillwork itwillwork deleted the fix-card-one-of-view-layout branch February 7, 2025 17:05
@gravity-ui-bot gravity-ui-bot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocembocem bocembocem Awaiting requested review from bocembocem bocembocem is a code owner

@NasgulNexus NasgulNexus Awaiting requested review from NasgulNexus NasgulNexus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itwillwork @gravity-ui-bot @NasgulNexus