Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify rendering for railway=rail and railway=preserved #1785

Closed
matkoniecz opened this issue Aug 25, 2015 · 7 comments
Closed

unify rendering for railway=rail and railway=preserved #1785

matkoniecz opened this issue Aug 25, 2015 · 7 comments

Comments

@matkoniecz
Copy link
Contributor

Currently railway=rail and railway=preserved are rendered differently. I think that difference between these two features is relatively minor (railway=rail also may have really limited service or be limited to freight and both features are the same structures, with difference only in usage).

Rendering railway=preserved like railway=rail would allow to reduce complexity of map in place where it is not highly useful.

On encountering railway=preserved at http://www.openstreetmap.org/#map=18/48.03615/16.79425 its meaning was not clear and such surprise is probably quite typical given that tag is rare and rendering is not obvious.

In addition [railway:preserved=yes; railway=*] seems to be recommended tagging (at least according to http://wiki.openstreetmap.org/wiki/Tag:railway=preserved ).

Complete removal of railway=preserved is probably a poor idea at this moment given that it is used over 10k times.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Aug 25, 2015
@Gazer75
Copy link

Gazer75 commented Aug 25, 2015

Please do not combine these. It's nice to see what is a museum line and whats not.
The wiki page you link to also have it as deprecated. AFAIK all preserved museum lines should use railway=preserved as is listed in http://wiki.openstreetmap.org/wiki/Key:railway#Values

Maybe that section of rail you refer to should be railway=disused?

@pnorman
Copy link
Collaborator

pnorman commented Aug 25, 2015

In addition [railway:preserved=yes; railway=*] seems to be recommended tagging (at least according to http://wiki.openstreetmap.org/wiki/Tag:railway=preserved ).

Looking at the usage data, I'd disregard what the wiki says and prefer railway=preserved.

Given the similarity, I'd support rendering them the same and leave distinguishing them to a more specialized map style.

@Gazer75
Copy link

Gazer75 commented Aug 26, 2015

A preserved railway track is actually quite different than regular railway. There is no normal scheduled traffic on the line and it is often maintained by a group of volunteers and/or a private organization.

Why is there a need to change how it currently is? The details of the default osm map is what set it apart from other maps.
If there are railways tagged with preserved that should not then fix it instead of combining them.
Combining them might make people think that there is a regular service on the line. This also include freight which at least around here is a regular thing.

@matkoniecz
Copy link
Contributor Author

Why is there a need to change how it currently is? The details of the default osm map is what set it apart from other maps.

See #1630. In general - we reached point where maintainers of map are sometimes unable to understand what is displayed on map.

And number of displayed features is still increasing (see https://github.com/matkoniecz/CartoCSSHelper/commits/master/lib/cartocss_helper/style_specific/default_osm_style.rb), we need also to remove less useful distinctions to keep map usable.

@gravitystorm
Copy link
Owner

I'd prefer to keep the distinction - as @Gazer75 says, there are significant differences between them, in terms of operations, services, prices etc.

@matkoniecz
Copy link
Contributor Author

So once proper tagging will be introduced we will start displaying also freight-only railway lines in a separate style?

I think that it would be too much for general purpose map - and in that case differences would be even more significant.

@Gazer75
Copy link

Gazer75 commented Aug 26, 2015

The more the merrier I say :) So I can't really agree with #1630. Only issue might be where to many POIs overlap, but this railway thing is not a problem.

Have to admit I didn't realize there are railways that only do freight. But then I am from Norway with barely 5 million people and an old and outdated rail network. Freight run on the same tracks and mostly at night. No space on our mostly single track network during the day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants