You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rework DaffMediaGalleryComponent to support videos
The Desired Behavior
The thumbnails in the media gallery should be smaller versions of the main image, and if it's a video, it should show a small image of a video (not the video itself) in the thumbnail. The current implementation ends up displaying the actual videos in the thumbnail, which is not what we want.
Your Use Case
Prior Work
Environment
Daffodil version: X.Y.Z
Angular version: X.Y.Z
For Tooling issues:
- Node version: XX
- Platform:
Others:
The text was updated successfully, but these errors were encountered:
xelaint
changed the title
[FEAT] Rework DaffMediaGalleryComponent to support videos
[FEAT] Rework DaffMediaGalleryComponent to support videos
Sep 4, 2024
Currently, the daff-media-gallery renders the component you gave it in the list of thumbnails. This means that we're double rendering a component, which is probably a bad idea.
<!-- Possible Correct Implementaton --><daff-media-gallery><ul><li><daff-image></daff-image></li><li><daff-image></daff-image></li><li><daff-image></daff-image></li><li><daff-image></daff-image></li><li><daff-image></daff-image></li></ul><div><daff-video></daff-video></div></daff-media-gallery>
<!-- Possible Correct Implementaton --><daff-media-gallery><ul><li><img/></li><li><img/></li><li><img/></li><li><img/></li><li><img/></li></ul><div><daff-video></daff-video></div></daff-media-gallery>
💡 Feature request
Feature Name
Rework
DaffMediaGalleryComponent
to support videosThe Desired Behavior
The thumbnails in the media gallery should be smaller versions of the main image, and if it's a video, it should show a small image of a video (not the video itself) in the thumbnail. The current implementation ends up displaying the actual videos in the thumbnail, which is not what we want.
Your Use Case
Prior Work
Environment
The text was updated successfully, but these errors were encountered: