feat(daffio): add sidebar section strategy support #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griest024
commented
Jan 22, 2025
xelaint
requested changes
Jan 27, 2025
| @@ -1,12 +1,21 @@ | |||
| import { DaffSidebarRegistration } from '@daffodil/design/sidebar'; | |||
| import { | |||
There was a problem hiding this comment.
Can you rename this file to sidebar-registration.type.ts
| @@ -0,0 +1,6 @@ | |||
| import { DaffioSidebarSectionStrategy } from './type'; | |||
There was a problem hiding this comment.
Can you rename this file to sidebar.strategies.ts or sidebar-strategies.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3447
What is the new behavior?
Does this PR introduce a breaking change?
Other information