Fix: Releasing GoLang projects

Sq
greenbone · Feb 10, 2023 · aa0abb6 · aa0abb6
1 parent 3790cb0
commit aa0abb6
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/pontos/git/git.py b/pontos/git/git.py
@@ -332,7 +332,7 @@ def commit(
             verify: Set to False to skip git hooks
             gpg_signing_key: GPG Key ID to use to sign the commit
         """
-        args = ["commit", "--verbose"]
+        args = ["commit"]
         if verify is False:
             args.append("--no-verify")
         if gpg_signing_key:

diff --git a/pontos/release/helper.py b/pontos/release/helper.py
@@ -25,6 +25,7 @@
 from pontos.git import Git, GitError
 from pontos.terminal import Terminal
 from pontos.version import COMMANDS
+from pontos.version.go import GoVersionCommand
 from pontos.version.helper import VersionError
 
 DEFAULT_TIMEOUT = 1000
@@ -229,6 +230,8 @@ def update_version(
         command = cmd()
         project_file = command.project_file_found()
         if project_file:
+            if isinstance(command, GoVersionCommand):
+                project_file = Path.cwd() / "version.go"
             break
 
     if not project_file:

diff --git a/tests/release/test_helper.py b/tests/release/test_helper.py
@@ -112,7 +112,11 @@ def test_find_no_signing_key(self):
     def test_update_version_not_found(self):
         terminal = MagicMock()
 
-        with temp_directory(change_into=True):
+        with temp_directory(change_into=True), patch.object(
+            Git,
+            "list_tags",
+            MagicMock(return_value=["21.4.4"]),
+        ):
             executed, filename = update_version(
                 terminal, to="21.4.4", develop=True
             )
@@ -123,7 +127,13 @@ def test_update_version_not_found(self):
     def test_update_version_no_version_file(self):
         terminal = MagicMock()
 
-        with temp_directory(change_into=True, add_to_sys_path=True) as tmp_dir:
+        with temp_directory(
+            change_into=True, add_to_sys_path=True
+        ) as tmp_dir, patch.object(
+            Git,
+            "list_tags",
+            MagicMock(return_value=["1.2.3"]),
+        ):
             module_path = tmp_dir / "testrepo"
             module_path.mkdir(parents=True, exist_ok=True)
 

diff --git a/tests/version/test_go_version.py b/tests/version/test_go_version.py
@@ -145,6 +145,7 @@ def test_no_file_but_tag_update_version(self):
                 self.assertIn(version, content)
                 self.assertEqual(updated_version_obj.previous, "21.0.1")
                 self.assertEqual(updated_version_obj.new, version)
+                version_file_path.unlink()
 
     def test_update_version(self):
         with temp_file(
@@ -161,6 +162,7 @@ def test_update_version(self):
 
             content = version_file_path.read_text(encoding="utf-8")
             self.assertIn(version, content)
+            version_file_path.unlink()
 
     def test_create_file_update_version(self):
         with temp_file(
@@ -179,6 +181,7 @@ def test_create_file_update_version(self):
                 version_file_path = Path(VERSION_FILE_PATH)
                 content = version_file_path.read_text(encoding="utf-8")
                 self.assertIn(version, content)
+                version_file_path.unlink()
 
 
 class ProjectFileGoVersionCommandTestCase(unittest.TestCase):