-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on IE11 in case use xstyled 2.3.0 and later #247
Comments
agriffis
added a commit
to agriffis/xstyled
that referenced
this issue
Apr 26, 2021
agriffis
added a commit
to agriffis/xstyled
that referenced
this issue
Apr 26, 2021
agriffis
added a commit
that referenced
this issue
Apr 26, 2021
Thanks! |
agriffis
added a commit
that referenced
this issue
Apr 26, 2021
@gregberge I put the fix for this on main and next. Do you want to make a v2 release? |
Fixed in v2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
IE11 & core-js is not support RegExp dotAll flag.
dotAll
flag zloirock/core-js#792So IE11 throw
Error: TypeError: Syntax error in regular expression
in xstyled 2.3.0 and later.Probably need to fix the following code to resolve this issue.
https://github.com/gregberge/xstyled/blob/main/packages/core/src/transform.ts#L32
For example, stop using the dotall flag and use
[\s\S]
instead of.
.https://stackoverflow.com/questions/1068280/javascript-regex-multiline-flag-doesnt-work
To Reproduce
To transpile application by babel 7 & core-js 3, that using xstyled 2.3.0 and later. and exec on IE11.
Expected behavior
Woking on IE11
Link to repl or repo (highly encouraged)
Sorry, I'm not ready yet.
Run
npx envinfo --system --binaries --npmPackages @xstyled/system,@xstyled/styled-components,styled-components --markdown --clipboard
The text was updated successfully, but these errors were encountered: