Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query51a - erroneous line break #33

Closed
gregrahn opened this issue May 20, 2017 · 4 comments
Closed

query51a - erroneous line break #33

gregrahn opened this issue May 20, 2017 · 4 comments
Labels
bug

Comments

@gregrahn
Copy link
Owner

gregrahn commented May 20, 2017 •
edited
Loading

Line 90 has an erronous line break causing the column alias to be on two lines. Seems like an obvious mistake.

select v1.item_sk, v1.d_date, v1.web_sales, v1.store_sales, max(v2.web_sales) web_cumulative, max(v2.store_sales) s
tore_cumulative
@gregrahn
Copy link
Owner Author

gregrahn commented May 20, 2017 •
edited
Loading

Fixed in this repo via 9ef085d

@gregrahn gregrahn added the bug label May 20, 2017
@gregrahn
Copy link
Owner Author

Present in v2.4.0

@gregrahn gregrahn changed the title query51a.tpl - erroneous line break query51a - erroneous line break Jun 10, 2017
@gregrahn
Copy link
Owner Author

Present in v2.6.0

@gregrahn
Copy link
Owner Author

gregrahn commented Jul 22, 2018 •
edited
Loading

Fixed in v2.9.0

$ diff v2.8.0rc4/query_variants/query51a.tpl v2.9.0rc2/query_variants/query51a.tpl
90,91c90
<         select v1.item_sk, v1.d_date, v1.web_sales, v1.store_sales, max(v2.web_sales) web_cumulative, max(v2.store_sales) s
< tore_cumulative
---
>         select v1.item_sk, v1.d_date, v1.web_sales, v1.store_sales, max(v2.web_sales) web_cumulative, max(v2.store_sales) store_cumulative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregrahn