Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt for the driver incorrectly displays the termsocket protocol #21

Closed
gridhead opened this issue Apr 15, 2021 · 2 comments · Fixed by #25
Closed

Prompt for the driver incorrectly displays the termsocket protocol #21

gridhead opened this issue Apr 15, 2021 · 2 comments · Fixed by #25
Assignees
@gridhead
Labels
anatomy Changes are more than what meets the eye documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@gridhead
Copy link
Owner

The designated protocol for termsocket shows up as HTTP (incorrect), while it should be WS (correct).

The following is the incorrect log output.

 ,---.                    .    ,o               
 `---..   .,---.,---.,---.|    |.,---.,---.,---.
     ||   ||   ||---'|     \  / |`---.|   ||    
 `---'`---'|---'`---'`      `'  ``---'`---'`    
           |
 * Driver Service v1.2.0-beta
 * Passcode          : 1435738C7EFB8D9B
 * Sync URI          : http://:8888/
 * TermSocket URI    : http://:6969/
 * Monitor service   : Psutil v5.8.0
 * Container service : DockerPy v4.4.1
 * Datastore service : RedisPy v3.5.3
 * WebSocket service : Terminado v0.9.2
 * Endpoint service  : Falcon v2.0.0
 * HTTP server       : Werkzeug v1.0.1
 * Starting Redis datastore server...

This needs to be changed at DockerHub documentation as well along with the code.

Once the changes are updated, corrected releases must be promptly pushed.
@gridhead gridhead added documentation Improvements or additions to documentation good first issue Good for newcomers anatomy Changes are more than what meets the eye labels Apr 15, 2021
@gridhead
Copy link
Owner Author

Thanks @khallnayak for marking out this issue.

@gridhead gridhead mentioned this issue May 12, 2021
Merged
@gridhead gridhead linked a pull request May 12, 2021 that will close this issue
Corrected TermSocket protocol notation from HTTP to WS #25
Merged
@gridhead
Copy link
Owner Author

Closed via #25.

@gridhead gridhead self-assigned this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gridhead gridhead

Labels
anatomy Changes are more than what meets the eye documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected TermSocket protocol notation from HTTP to WS gridhead/supervisor-driver-service
1 participant
@gridhead