Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TINY] Some colors are hard coded instead of using grist-var-colors. #1269

Closed
1 of 2 tasks
hexaltation opened this issue Oct 16, 2024 · 0 comments · Fixed by #1270
Closed
1 of 2 tasks

[TINY] Some colors are hard coded instead of using grist-var-colors. #1269

hexaltation opened this issue Oct 16, 2024 · 0 comments · Fixed by #1270
Assignees
Labels
-UX/UI bug Something isn't working gouv.fr Styling

Comments

@hexaltation
Copy link
Collaborator

Describe the current behavior

Start a new document background on the new page is hard coded to #DCF4EB . For custom.css to properly apply it would be better to set it to --grist-color-selection-opaque.

Steps to reproduce

  1. overload --grist-color-selection-opaque in custom.css with some distinctive color.
  2. see that it don't apply for Start a new document background

Describe the expected behavior

The base color overloaded in custom.css must apply to every element in grist.

Where have you encountered this bug?

Instance information (when self-hosting only)

  • Grist instance:

    • Version: 1.2.0
    • URL (if it's OK for you to share it): grist.numerique.gouv.fr
    • Installation mode: kubernetes
    • Architecture: multi-workers
  • Browser name, version and platforms on which you could reproduce the bug: firefox 130.0.1

@hexaltation hexaltation added bug Something isn't working gouv.fr Styling -UX/UI labels Oct 16, 2024
@hexaltation hexaltation self-assigned this Oct 16, 2024
@hexaltation hexaltation changed the title Some colors are hard coded instead of using grist-var-colors. [TINY] Some colors are hard coded instead of using grist-var-colors. Oct 30, 2024
@github-project-automation github-project-automation bot moved this to To Review in Grist UI/UX Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Needs feedback to Done in French administration Board Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-UX/UI bug Something isn't working gouv.fr Styling
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant