Informational - Duplicate strategies possible with setStrategies()

[kitty-the-kat]

setStrategies() can store the same strategy more than once in the strategies array. This is specifically prevented in _addStrategy(), unlike many owner-controlled functions which have no safety guards.

Technical Details

_addStrategy() does not permit a strategy to be added to the strategies array if it is already in the array. But the owner could use setStrategies() to do the same.

Impact

Informational.

Recommendation

Remove the safety check for duplicate strategies in _addStrategy() which provides a false sense of security.

[kitty-the-kat]

acknowledged - see #60 for clarification regarding the functionality of the setStrategy function. Wont add this fix right now as this can be handled