Make ObjectProperty 'close' height consistent #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for blissful-poincare-c75feb accepted.
|
jcfilben
reviewed
Feb 1, 2024
Comment on lines
37
to
+46
| <Button | ||
| icon={<FormClose />} | ||
| tip={`clear ${name}`} | ||
| hoverIndicator | ||
| onClick={() => onChange(undefined)} | ||
| /> | ||
| pad={{ vertical: 'xsmall', horizontal: 'small' }} | ||
| > | ||
| <Box pad={{ vertical: 'xsmall', horizontal: 'small' }}> | ||
| <FormClose /> | ||
| </Box> | ||
| </Button> |
There was a problem hiding this comment.
Can we change this to
<Button
icon={<FormClose />}
tip={`clear ${name}`}
hoverIndicator
onClick={() => onChange(undefined)}
plain
fill="vertical"
/>
Then I think we don't need the changes to flex on the other lines
There was a problem hiding this comment.
Thanks for the feedback, I'll try that out soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135 by making the composition of the
ObjectPropertycomponent closer to that of theFunctionProperty.Now it looks like this:
test,e2e, andprettierall pass.