-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking UI updates when updating #104
Comments
Could you provide a reproduction code? |
I noticed something similar in ios, there is no problem when I forceupdate. fallbackComponent is shown and reload works successfully, but when forceupdate is false. when the application is first opened, the ui is blocked during the update time, fallbackComponent is not shown and navigation operations do not occur because the ui is blocked. version 0.7.0 |
@gronxb @mstfmedeni I think the issue is with the native @gronxb I would provide a JS example but the way our project does updates (or used to do them in CodePush) is a little complex. |
Ok @gronxb @mstfmedeni this seems to fix it: |
@ewindso It seems to be fixed. thank you for your support and feedback |
@gronxb @mstfmedeni just fyi sending events was happening too quick for me on iOS, UI thread was getting clogged... I added this in, seems to fix: |
I got the same issue with the latest version (v0.12.0) on Android. |
@minhchienwikipedia Can you provide video or reproduction? |
Thanks for making this! One thing I notice is that when I check for an update after come back from the background, the UI seems blocked. This doesn't happen when it's initially updating using the same method (
runUpdateProcess
).However when coming back from the background, it also checks for an update -- and if there is one, the UI is blocked from interaction. (ScrollViews scroll, but taps do not work, cannot do anything else.) Also, even the progress from
useHotUpdaterStore
seems not to update.This is on iOS. I haven't yet gotten to Android, just wanting to get past this. One potential workaround I see is showing a full-screen splash screen, with a spinner (loading progress won't work since it can't update UI...)
Any help on fixing it would be appreciated! Thank you.
The text was updated successfully, but these errors were encountered: