Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeshaking google-api-php-client-services? #3

Open
myselfhimself opened this issue Jun 7, 2024 · 2 comments
Open

Treeshaking google-api-php-client-services? #3

myselfhimself opened this issue Jun 7, 2024 · 2 comments

Comments

@myselfhimself
Copy link

Hello,

the amount of libraries in groundhogg-appointments/includes/lib/google/vendor/google/apiclient-services/ is much too big (almost a thousand files, many unused sub libraries).

I realized that when downloading a website containing the groundhogg-appointments plugin over FTP.

What about reworking the composer.json file and using only the necessary libraries from there https://cloud.google.com/php/docs/reference ?

This Github page itself mentions explicitly https://github.com/googleapis/google-api-php-client-services?tab=readme-ov-file :
NOTE: please check to see if the package you'd like to install is available in our list of [Google cloud packages](https://cloud.google.com/php/docs/reference) first, as these are the recommended libraries.

🌴 ▶️ 🥥

@myselfhimself
Copy link
Author

find wp-content/plugins/groundhogg-appointments/includes/lib | wc -l
# ->   17799 files

@BrianHenryIE
Copy link
Collaborator

BrianHenryIE commented Jun 7, 2024

Calendar doesn't exist in the Google list of "recommended libraries", unfortunately.

There's an unmerged branch where the Google\Task\Composer::cleanup is working correctly, by running it on post-install-cmd and post-update-cmd rather than pre-autoload-dump.

9398074...prefix-namespace

https://github.com/groundhoggwp/groundhogg-appointments/tree/prefix-namespace

I don't know why the branch has diverged from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants