Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14.x breaks clay #1161

Closed
utrack opened this issue Mar 8, 2020 · 2 comments · Fixed by #1163
Closed

1.14.x breaks clay #1161

utrack opened this issue Mar 8, 2020 · 2 comments · Fixed by #1163

Comments

@utrack
Copy link
Contributor

utrack commented Mar 8, 2020

Hi! After 1.14.0's internalization protoc-gen-goclay is broken in a same way #1154 was - it depends on genswagger package, which was moved behind internal/.

Is there any way to retrieve []byte of a Swagger definition without invoking genswagger directly?

I'm wondering if it'd be worth it to split protoc-gen-swagger to a separate package. I feel that it may be useful for other languages since JSON spec is more or less standard.

@johanbrandhorst
Copy link
Collaborator

Hi, sorry about breaking your build. I'll move it back into the public namespace and release 1.14.2.

I'm wondering if it'd be worth it to split protoc-gen-swagger to a separate package. I feel that it may be useful for other languages since JSON spec is more or less standard.

What do you mean by this? It translates proto options to a swagger file, in some case our internal options. I don't know how generic it can really be made.

@utrack
Copy link
Contributor Author

utrack commented Mar 10, 2020

Thank you, that works perfectly :)

Ah, I didn't account for options defined by grpc-gateway.
Without them, google.api.http and protobuf-to-JSON schema should work the same for all languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants