-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-swagger: json_names_for_fields=true does not respect json_name for *nested* path parameters #1187
Comments
Seems right. Are you saying this was broken by the change or that it wasn't supported to begin with and still isn't supported? Would you be interested in fixing this? CC @xin-au |
@johanbrandhorst I don't think this was ever supported. It might be a case which was not captured in #1084 |
@johanbrandhorst , @brocaar , thanks for pointing it out! I will be working on it. Sorry about that. |
Thank you @xin-au ! |
@brocaar , @johanbrandhorst , quick update: |
@brocaar , @johanbrandhorst , update: |
@brocaar @johanbrandhorst , just created a PR #1191 |
This is probably related to #1084 which was fixed by #1084.
Version: v1.14.3
Does result in the expected endpoint:
/api/devices/{devEUI}
.However, if the Protobuf definition is modified to:
The expected endpoint would be:
/api/devices/{device.devEUI}
.However, the actual generated endpoint is:
/api/devices/{device.devEui}
.Could it be that in case of a nested argument, the
GetJsonName()
is not triggered?The text was updated successfully, but these errors were encountered: