Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in generator when package name conflicts #17

Closed
sjincho opened this issue May 31, 2015 · 0 comments
Closed

Infinite loop in generator when package name conflicts #17

sjincho opened this issue May 31, 2015 · 0 comments

Comments

@sjincho
Copy link

sjincho commented May 31, 2015

https://github.com/gengo/grpc-gateway/blob/master/protoc-gen-grpc-gateway/gengateway/generator.go#L48

alias := fmt.Sprintf("%s_%d", pkg.Name, i)
if err := reg.ReserveGoPackageAlias(pkg.Name, pkg.Path); err != nil {
    continue
}

reg.ReserveGoPackageAlias(pkg.Name, pkg.Path) should be reg.ReserveGoPackageAlias(alias, pkg.Path) instead.
@yugui yugui closed this as completed in f748a47 Jun 1, 2015
ithinker1991 referenced this issue in tronprotocol/grpc-gateway Apr 26, 2018
@CodeNinjaEvan
Merge pull request #17 from tronprotocol/feature/add_TotalTransaction
ba4df02 
add TotalTransaction method return all TotalTransaction amount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjincho