Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger: incorrect documentation for proto wrapper types #367

Closed
charles-crain opened this issue Apr 18, 2017 · 2 comments
Closed

Swagger: incorrect documentation for proto wrapper types #367

charles-crain opened this issue Apr 18, 2017 · 2 comments

Comments

@charles-crain
Copy link

If you have a response object that looks like this:

message FooResponse {
  google.protobuf.DoubleValue some_value = 1;
}

Then the generated Swagger says the response looks like:

{
  "some_value" : {
    "value" : 0
  }
}

When in fact the JSON returned from calling the method looks like:

{
  "some_value" : 0
}
@tmc
Copy link
Collaborator

tmc commented Apr 19, 2017

@charles-crain thank you for your issue report. That's an unfortunate divergence there. One solution might be to add protobuf WKT support in the swagger generation. Perhaps we can be smarter.

@stale
Copy link

stale bot commented Sep 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 9, 2019
@stale stale bot closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants