Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the build environment Dockerfile to Go 1.12 #885

Closed
johanbrandhorst opened this issue Mar 1, 2019 · 3 comments
Closed

Update the build environment Dockerfile to Go 1.12 #885

johanbrandhorst opened this issue Mar 1, 2019 · 3 comments
Assignees
@johanbrandhorst
Labels
enhancement good first issue help wanted

Comments

@johanbrandhorst
Copy link
Collaborator

It's currently locked to using Go 1.11 as per #884. Upgrading to 1.12 was causing some builds to fail, so it should be made as part of a separate pull request.
@johanbrandhorst
Copy link
Collaborator Author

Might want to consider other dependencies in the same file at the same time, namely protoc is still 3.1.0.

@johanbrandhorst johanbrandhorst self-assigned this Mar 2, 2019
@MichaHoffmann
Copy link

Hey, is this still up for grabs?

@johanbrandhorst
Copy link
Collaborator Author

It's going to be a little hard to do without push access to the build-env-image docker hub repo, so I assigned it to myself. Sorry it's probably a bit poorly labeled.

@johanbrandhorst johanbrandhorst mentioned this issue Mar 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanbrandhorst johanbrandhorst

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanbrandhorst @MichaHoffmann