Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of serving HTTP 1 request with servers running GRPC? #1532

Closed
thefallentree opened this issue Mar 9, 2016 · 9 comments
Closed

Examples of serving HTTP 1 request with servers running GRPC? #1532

thefallentree opened this issue Mar 9, 2016 · 9 comments

Comments

@thefallentree
Copy link

Hi,

Is there a example of using grpc/underlay netty to serve HTTP1/1 on the same port?

Cheers.

@thefallentree thefallentree changed the title Examples of serving HTTP 1/1 request with servers running GRPC? Examples of serving HTTP 1 request with servers running GRPC? Mar 9, 2016
@ejona86
Copy link
Member

ejona86 commented Mar 9, 2016

No, we don't provide such an example and it isn't really much of a supported use-case at present. I do know it is possible, but it is a bit tricky and not something I would generally encourage.

Longer-term, with some upstream Netty API changes we would hope to support more advanced Netty use-cases, for example, by providing a GrpcHandler.

@thefallentree
Copy link
Author

Thanks,

We are currently using jetty to serve http needs, and grpc for rpc part. Would there be a problem other than having two I/O stack running at the same time? (maybe there is even advantage of that )

@ejona86
Copy link
Member

ejona86 commented Mar 10, 2016

Having both running shouldn't be too much of a problem. You'll need to configure a port for it to run on, which may be a little annoying, but everything should function.

@ejona86
Copy link
Member

ejona86 commented Apr 19, 2016

This seems to be resolved.

@ejona86 ejona86 closed this as completed Apr 19, 2016
@kuroneko25
Copy link

We actually have a similar need because we run gRPC based services on Google Container Engine and utilize their managed load balancer which uses HTTP health checks by default. This poses a challenge since the load balancer expects to hit the same port to do its HTTP health check. Are there plans to do something similar like grpc/grpc-go#514? If not what is the recommended approach for handling HTTP based health checks?

@ejona86
Copy link
Member

ejona86 commented Oct 7, 2016

@kuroneko25, I'd recommend you run an HTTP server on a different port. Sharing with HTTP is a complicated target, and it's a bit unclear where we'll end up (it depends some on the performance of netty/netty#3667 and how we utilize it in grpc)

@jchapuis
Copy link

Any news on this front? Also would like to expose the REST and grpc endpoints on the same port. Thanks

@jared2501
Copy link

netty/netty#3667 would be great - would be nice to be able to run gRPC and other HTTP/2 services on the same port.

@jared2501
Copy link

Ah looks like #3458 is the new, open GH issue tracking this FR

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants