Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate usage of io.grpc.internal.TimeProvider for time stamp and backoff #5056

Closed
dapengzhang0 opened this issue Nov 13, 2018 · 2 comments
Closed

Separate usage of io.grpc.internal.TimeProvider for time stamp and backoff #5056

dapengzhang0 opened this issue Nov 13, 2018 · 2 comments
Assignees
@voidzcy
Labels
bug
Milestone
1.20

Comments

@dapengzhang0
Copy link
Member

dapengzhang0 commented Nov 13, 2018 •
edited
Loading

Now TimeProvider is used for both time stamp and backoff. Time stamp should reflect system clock changes (?) whereas backoff duration should be absolute amount of time of delay.

Related to #4883.
@ejona86 ejona86 added the bug label Nov 16, 2018
@ejona86 ejona86 added this to the Next milestone Nov 16, 2018
@dapengzhang0 dapengzhang0 self-assigned this Nov 20, 2018
@dapengzhang0
Copy link
Member Author

@voidzcy I'd like to assign this to you.

@dapengzhang0 dapengzhang0 assigned voidzcy and unassigned dapengzhang0 Mar 8, 2019
@voidzcy voidzcy mentioned this issue Mar 22, 2019
Merged
@zhangkun83 zhangkun83 mentioned this issue Mar 24, 2019
Closed
@dapengzhang0
Copy link
Member Author

Fixed by #5491

@ejona86 ejona86 modified the milestones: Next, 1.20 May 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@voidzcy voidzcy

Labels
bug
Projects
None yet
Milestone
1.20
Development

No branches or pull requests
3 participants
@voidzcy @ejona86 @dapengzhang0