Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXX should not be hardcoded to g++ #690

Closed
abbec opened this issue Dec 6, 2019 · 1 comment · Fixed by #692
Closed

CXX should not be hardcoded to g++ #690

abbec opened this issue Dec 6, 2019 · 1 comment · Fixed by #692

Comments

@abbec
Copy link

abbec commented Dec 6, 2019

When using nix to create a custom derivation on macOS for building protoc-gen-grpc-web I ran into an issue where the protobuf libraries in nixpkgs are compiled with clang and the Makefile inside javascript/net/grpc/web hardcodes CXX to g++.

It builds fine if CXX is set to clang++ so I would propose changing the Makefile line to read

CXX ?= g++
...

to default to g++ but still allow overrides.

@stanley-cheung
Copy link
Collaborator

@abbec Thanks for the issue report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants