issue #513: allow stop when not started #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 13, 2020
ColinDKelley
commented
Nov 13, 2020
lib/listen/event/loop.rb
Outdated
| @@ -67,7 +67,7 @@ def stop | |||
| return if stopped? | |||
| transition! :stopped | |||
|
|
|||
| if @wait_thread.alive? | |||
| if @wait_thread&.alive? | |||
There was a problem hiding this comment.
Feeback from @ioquatix
I think you can just do @wait_thread.join
the if statement, is a race condition
True! And building on that, the return if stopped? is a race condition too. I'm getting rid of both, in favor of simply @wait_thread&.join.
…h are unnecessary race conditions
ioquatix
approved these changes
Nov 13, 2020
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #513 .
This issue wasn't being caught by the unit tests because they stub the processor entirely. So I added a couple tests to
acceptance_test.Note: I changed the indentation to add a new
context, so this is best reviewed with "hide whitespace changes".