Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: guardian/play-googleauth
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.1
Choose a base ref
...
head repository: guardian/play-googleauth
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.2
Choose a head ref
  • 6 commits
  • 4 files changed
  • 4 contributors

Commits on Jun 13, 2024

  1. Unverified

    This user has not yet uploaded their public signing key.
    Copy the full SHA
    ee2e34e View commit details
  2. Remove unused message val

    This follows on from #233 -
    it turns out the `message` val is now unused, so we can remove it, and simplify
    the code a little!
    
    PR #233 removed the exception message text from the error displayed to the end user,
    because the error message text is unconstrained and this corresponds to
    https://owasp.org/www-community/Improper_Error_Handling .
    
    I was tempted to include the `desc` string in the error message displayed to the user,
    as it is just the string "anti-forgery-token-invalid" or the exception class name, which
    is more constrained, but re-reading the OWASP doc, this is also discouraged as it's
    very similar to an error code. ("internal error messages such as stack traces, database
    dumps, and error codes"). When getting error reports in the past, I've found it helpful if
    they have received an error with a bit more context in it, as surprisingly the error reports
    often don't include the user that saw the error, or when the error occurred, making it harder
    to search logs for them! Still, I do appreciate the guidance from OWASP is right.
    rtyley committed Jun 13, 2024
    Copy the full SHA
    de83b0e View commit details
  3. Merge pull request #234 from guardian/remove-unused-message-val

    Remove unused `message` val
    rtyley authored Jun 13, 2024
    Copy the full SHA
    c07f923 View commit details

Commits on Jun 20, 2024

  1. Use token auth for Sonatype - see guardian/gha-scala-library-release-…

    rtyley committed Jun 20, 2024
    Copy the full SHA
    3bcfcb8 View commit details
  2. Update ssm to 2.25.63 (#232)

    Co-authored-by: gu-scala-steward-public-repos[bot] <108136057+gu-scala-steward-public-repos[bot]@users.noreply.github.com>
    gu-scala-steward-public-repos[bot] authored Jun 20, 2024
    Copy the full SHA
    e125c13 View commit details
  3. v8.0.2 published by JamieB-gu

    JamieB-gu published release version 8.0.2
    using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow
    
    Release-Version: 8.0.2
    Release-Initiated-By: https://github.com/JamieB-gu
    Release-Workflow-Run: https://github.com/guardian/play-googleauth/actions/runs/9600561153
    GitHub-Release-Notes: https://github.com/guardian/play-googleauth/releases/tag/v8.0.2
    gu-scala-library-release[bot] authored Jun 20, 2024
    Copy the full SHA
    78988e5 View commit details
Loading