-
Notifications
You must be signed in to change notification settings - Fork 11
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: guardian/play-googleauth
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: guardian/play-googleauth
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 4 files changed
- 4 contributors
Commits on Jun 13, 2024
-
Post-release of v8.0.1 by @johnduffell: set snapshot version
Setting snapshot version after @johnduffell published https://github.com/guardian/play-googleauth/releases/tag/v8.0.1
Configuration menu - View commit details
-
Copy full SHA for ee2e34e - Browse repository at this point
Copy the full SHA ee2e34eView commit details -
This follows on from #233 - it turns out the `message` val is now unused, so we can remove it, and simplify the code a little! PR #233 removed the exception message text from the error displayed to the end user, because the error message text is unconstrained and this corresponds to https://owasp.org/www-community/Improper_Error_Handling . I was tempted to include the `desc` string in the error message displayed to the user, as it is just the string "anti-forgery-token-invalid" or the exception class name, which is more constrained, but re-reading the OWASP doc, this is also discouraged as it's very similar to an error code. ("internal error messages such as stack traces, database dumps, and error codes"). When getting error reports in the past, I've found it helpful if they have received an error with a bit more context in it, as surprisingly the error reports often don't include the user that saw the error, or when the error occurred, making it harder to search logs for them! Still, I do appreciate the guidance from OWASP is right.
Configuration menu - View commit details
-
Copy full SHA for de83b0e - Browse repository at this point
Copy the full SHA de83b0eView commit details -
Merge pull request #234 from guardian/remove-unused-message-val
Remove unused `message` val
Configuration menu - View commit details
-
Copy full SHA for c07f923 - Browse repository at this point
Copy the full SHA c07f923View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3bcfcb8 - Browse repository at this point
Copy the full SHA 3bcfcb8View commit details -
Co-authored-by: gu-scala-steward-public-repos[bot] <108136057+gu-scala-steward-public-repos[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e125c13 - Browse repository at this point
Copy the full SHA e125c13View commit details -
JamieB-gu published release version 8.0.2 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 8.0.2 Release-Initiated-By: https://github.com/JamieB-gu Release-Workflow-Run: https://github.com/guardian/play-googleauth/actions/runs/9600561153 GitHub-Release-Notes: https://github.com/guardian/play-googleauth/releases/tag/v8.0.2
Configuration menu - View commit details
-
Copy full SHA for 78988e5 - Browse repository at this point
Copy the full SHA 78988e5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.0.1...v8.0.2