WIP: Pass redirect url through OAuth state #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtyley time to salvage or scrap this? |
I still want to complete this, just need the time! Happy to close it and come back with a new PR later if you want to reduce the number of open PRs? |
|
@rtyley no worries, I just want to avoid the work being lost |
TokenResponse is a better name for that endpoint More wip More wip WIP
rtyley
force-pushed
the
pass-redirect-url-through-state
branch
from
0acde46 to
2d6fb72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly massive partially-completed refactor, aiming to fix #57 by passing the redirect through url in the OAuth state, rather than in the
PLAY_SESSIONcookie.