Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequiredVersion of ConsoleGuiTools is outdated. #17

Closed
klennan opened this issue Oct 26, 2023 · 6 comments
Closed

RequiredVersion of ConsoleGuiTools is outdated. #17

klennan opened this issue Oct 26, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@klennan
Copy link

klennan commented Oct 26, 2023

F7History.psd1 has a hardcoded dependency on v0.7.4 of ConsoleGuiTools, which is now at v0.7.5.35

I suggest using "ModuleVersion" instead of "RequiredVersion" to make a softer minimum version dependency.

@tig tig added the bug Something isn't working label Oct 27, 2023
@RH-TLagrone
Copy link

I am having the same issue.

Microsoft.PowerShell.ConsoleGuiTools is now at version 0.7.6.0 as of 2023-10-27. This latest version includes the command Show-ObjectTree, which I am unable to use at the same time as F7History due to the version conflict.

I request allowing newer versions of Microsoft.PowerShell.ConsoleGuiTools as well. (i.e. replace the exact-version specifier RequiredVersion in F7History.psd1 with the minimum-version specifier ModuleVersion instead)

@tig
Copy link
Collaborator

tig commented Nov 2, 2023

Sorry about this folks.

I'm confused about ModuleVersion and RequiredVersion

In order to build/test locally, I have a build script that looks at a local PS repo for ConsoleGuiTools and if found updates F7History.ps1 to force use of it (updating RequiredVersion). This is what I pushed to this repo.

Can you point me at docs that show how to effectively use ModuleVersion instead.?

@RH-TLagrone
Copy link

No worries! Here's the doc:

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_module_manifests#moduleversion

Looking at your implementation, I think you could simply swap RequiredVersion for ModuleVersion and it would work just fine without needing any other changes.

@tig
Copy link
Collaborator

tig commented Nov 4, 2023

v1.4 has been published. I think I did it right ;-).

I had to disable my CI/CD unit tests (which are pretty lame anyway) because of Pester v5 and me being confused. I'll fix those asap.

Can y'all verify this was done correctly? If so I'll close this issue.

@tig
Copy link
Collaborator

tig commented Nov 6, 2023

Pretty sure v1.4.1 which was just published fixes this.

https://www.powershellgallery.com/packages/F7History/1.4.1

@tig tig closed this as completed Nov 6, 2023
@RH-TLagrone
Copy link

RH-TLagrone commented Nov 6, 2023

I can confirm that the issue is resolved. I am able to import and successfully use version 0.7.6.0 of the module Microsoft.PowerShell.ConsoleGuiTools simultaneously with version 1.4.1 of the module F7History.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants