-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Close/Quit/Collapse/Expand buttons on Border
#2814
Comments
I remember a long time ago, to add |
This will be easy to accomplish in v2 once adornments are full implemented. |
Border
Closing as dupe of #3407 |
Mini-Spec
Three scenarios so far:
We will create 3 new View subclasses, one for each of these:
ApplicationQuitter
- Glyph is an X.MouseClick
, andKeyBinding (Space)
invokeCommand.QuitToplevel
(to be renamed toCommand.Close
). The command handler simply callsApplication.RequestStop()
.ViewHider
- Glyph is an X.MouseClick
, andKeyBinding (Space)
invokeCommand.Close
. The command handler simply callsSuperView.Parent.Visible = false
. (or perhaps we addClose()
as a verb on View?).ViewExpander
- Glyph is a up/down arrow.MouseClick
, andKeyBinding (Space)
invokeCommand.ToggleExpandCollapse
. Command handerSuperView.Parent
's subviewsSuperView.Parent
to 3 orDim.Auto
Devs will add these views via
view.Border.Add
.This is what
ViewExpander
will look like/do:I've built a POC of
ViewExpander
in #3376Background
This is a sub-issue of:
Will be fixed in this PR as a proof:
FindDeepestView
to supportAdornment
#3278Background
Is your feature request related to a problem? Please describe.
I want user to be able to close button by [X] button near dialog title from top right side. And I want them to be shown in Query dialogs by default. Because when you pass no button its not clear, that you need Escape button to be pressed to close it.
Describe the solution you'd like
For dialogs and querries to have [x] button: Dialog Title [x]
Describe alternatives you've considered
Have close button as now.
The text was updated successfully, but these errors were encountered: