Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views must not blindly return true from Command functions #3631

Open
tig opened this issue Jul 31, 2024 · 0 comments
Open

Views must not blindly return true from Command functions #3631

tig opened this issue Jul 31, 2024 · 0 comments
Labels
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Jul 31, 2024

I discovered this as I've beefed up how keyboard nav works in #3627.

Examples:

  • ListView - blindly returns true from MoveUp/MoveDown even if the selection was not changed (e.g. MoveUp when at the top of the list). As a result, pressing Up when at the top of the list does not allow keyboard nav to change focus to the "previous view".
  • TableView - blindly returns true from all relevant Command handlers. No arrow keys work to move to next/prev view. In addition, TableView always return true from the Command.Accept handler. This prevents the default button in a Dialog from working when a TableView is used.

I will be adding an all-views test in #3627 that highlights any view that behaves improperly here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant