Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support INSERT key in addition to SPACE for selecting items in ListView #385

Open
tig opened this issue Apr 17, 2020 · 5 comments
Open

Support INSERT key in addition to SPACE for selecting items in ListView #385

tig opened this issue Apr 17, 2020 · 5 comments

Comments

@tig
Copy link
Collaborator

tig commented Apr 17, 2020

See this request here: PowerShell/ConsoleGuiTools#79 (comment)

Multi selection is also non-intuitive - not being able to close on Enter, nor using Insert for marking lines is very annoying behavior :(

@tig
Copy link
Collaborator Author

tig commented May 16, 2020

I've thought more about this and I think this is a bad idea. I do not know what existing UI framework uses INSERT to select items. INSERT feels very arbitrary to me. It has been a common idiom on Mac and Windows that space selects/deselects UI items.

@tig tig closed this as completed May 16, 2020
@BDisp
Copy link
Collaborator

BDisp commented May 16, 2020

It would really be a bad option in addition to the fact that this key has already been defined for the activation / deactivation of text insertion or overlay.

@yanrez
Copy link

yanrez commented Sep 29, 2020

INSERT is by default used to select items in both "Midnight Commander" and "Far Commander", which are very popular console file managers for Linux and Windows respectively. Not sure what people are using on Mac these days, assume mc as well?

@tig
Copy link
Collaborator Author

tig commented Sep 29, 2020

Shows you what I know.

I'm reopening this because the argument that folks used to those console tools might expect INS to select items is valid.

I'm curious: On MC and FC, what does INS do when in an edit field? Or on other controls like buttons and check boxes?

If someone wants to help contribute and submit a PR for this, we're open to that!

@tig tig reopened this Sep 29, 2020
@yanrez
Copy link

yanrez commented Sep 29, 2020

Thanks. I guess i just have too much muscle memory, keep hitting INSERT in console lists in file managers :) I've tried INS on my mc in both wsl and ubuntu vm, and I don't see it doing anything on edit fields or buttons. Neither bottom command nor edit box is reacting to INSERT.
I'll try to look into doing PR for that, will look around the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants