Skip to content

Commit

Permalink
Update: Refactor and reword tests
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Nov 30, 2017
1 parent 483d1cc commit e7191c1
Show file tree
Hide file tree
Showing 27 changed files with 2,212 additions and 2,434 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ node_js:
- '0.10'
before_script:
- find test -type d -exec chmod g+s {} \;
- sudo chown root test/not-owned/
- sudo chown root test/not-owned/not-owned.txt
- sudo chown root test/fixtures/not-owned/
- sudo chown root test/fixtures/not-owned/not-owned.txt
after_script:
- npm run coveralls
4 changes: 3 additions & 1 deletion lib/prepare-write.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ function prepareWrite(outFolder, file, opt, callback) {
file.stat.mode = options.mode;
file.flag = options.flag;
file.cwd = cwd;
file.base = basePath;
// Ensure the base always ends with a separator
// TODO: add a test for this
file.base = path.normalize(basePath + path.sep);
file.path = writePath;

fo.mkdirp(writeFolder, options.dirMode, onMkdirp);
Expand Down
10 changes: 2 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,17 @@
"vinyl": "^1.0.0"
},
"devDependencies": {
"buffer-equal": "^0.0.1",
"default-resolution": "^1.0.1",
"del": "^2.2.0",
"eslint": "^1.10.3",
"eslint-config-gulp": "^2.0.0",
"expect": "^1.14.0",
"from2": "^2.1.1",
"github-changes": "^1.0.1",
"istanbul": "^0.3.0",
"istanbul-coveralls": "^1.0.1",
"jscs": "^2.4.0",
"jscs-preset-gulp": "^1.0.0",
"mocha": "^2.0.0",
"mocha-lcov-reporter": "^1.0.0",
"rimraf": "^2.2.5",
"should": "^7.0.0",
"sinon": "^1.10.3"
"mississippi": "^1.2.0",
"mocha": "^2.0.0"
},
"scripts": {
"lint": "eslint . && jscs index.js lib/ test/",
Expand Down
Loading

0 comments on commit e7191c1

Please sign in to comment.