Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHATWG stream errors should be emitted as Node errors #3

Open
pimterry opened this issue Jul 6, 2018 · 0 comments · May be fixed by #4
Open

WHATWG stream errors should be emitted as Node errors #3

pimterry opened this issue Jul 6, 2018 · 0 comments · May be fixed by #4

Comments

@pimterry
Copy link

pimterry commented Jul 6, 2018

This means any errors (e.g. if you try and read after the stream is closed) get reported as unhandled promise rejections instead.

I've got a fix for this in my own code - I'll open a PR to pull it into this repo shortly.

@pimterry pimterry linked a pull request Jul 6, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant